Skip to content

Do not monkeypatch window.document #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Do not monkeypatch window.document #62

wants to merge 1 commit into from

Conversation

alanhoff
Copy link
Contributor

@alanhoff alanhoff commented Oct 10, 2016 •
edited
Loading

Some libraries like RavenJS detects the environment by the existence of window.document so using firestack it thinks it's inside a browser.

Closes #52

auser
auser previously requested changes Oct 11, 2016
View reviewed changes
Copy link
Contributor

@auser auser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually breaks the debug logger:

http://d.pr/i/nj93.png

@auser
Copy link
Contributor

auser commented Oct 11, 2016

This breaks the debug logger (window.document). Perhaps we move to another debug library?

@alanhoff
Copy link
Contributor Author

@auser yeah we should probably exchange the debug lib since it's not friendly to unknown environments. They also seem to not had reached a conclusion yet about this problem bc it's a known bug since 2014.

I know that debug gives you the ability to have custom level but one idea would be using the current log methods that RN provides: console.log, console.error and console.warn.

Any ideas?

@auser
Copy link
Contributor

auser commented Oct 11, 2016

Yeah, we can probably do that with the Log class then.

auser added a commit that referenced this pull request Oct 16, 2016
@auser
Fixeds #62
f1e6ff4
@auser auser dismissed their stale review October 16, 2016 01:14

Pushed a new version without document patched

@auser auser closed this Oct 16, 2016
auser added a commit that referenced this pull request Oct 16, 2016
@auser
Merge branch 'master' into anonymous
a2cd599 
* master:
  Fixeds #62
  2.3.1
  Allow modular headers to be included
  Change asset upload to use data rather than file
  Bugfix in configuration using google-services.json
  Update README to include info about google-services.json
  Fix Android Storage, allow config via .json file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auser auser auser left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanhoff @auser